diff options
| author | Jokler <jokler.contact@gmail.com> | 2017-11-16 02:36:12 +0100 |
|---|---|---|
| committer | Jokler <jokler.contact@gmail.com> | 2017-11-16 02:36:12 +0100 |
| commit | e591ce43d3f9b85572f7ca179799fd6c3191f3ab (patch) | |
| tree | e3fafbfce1b8f3f3284c4dfb52285c14e60f1921 /src/plugins | |
| parent | 4c18f59ac4dfe1372374ecc63a5976ad58a5e272 (diff) | |
| download | frippy-e591ce43d3f9b85572f7ca179799fd6c3191f3ab.tar.gz frippy-e591ce43d3f9b85572f7ca179799fd6c3191f3ab.zip | |
Remove mutexes around plugins
Mutexes are supposed to only mark critical sections
so locking the entire plugin is too general.
Any plugins that need mutable data
should use mutexes internally instead.
Diffstat (limited to 'src/plugins')
| -rw-r--r-- | src/plugins/currency.rs | 4 | ||||
| -rw-r--r-- | src/plugins/emoji.rs | 4 | ||||
| -rw-r--r-- | src/plugins/help.rs | 4 |
3 files changed, 6 insertions, 6 deletions
diff --git a/src/plugins/currency.rs b/src/plugins/currency.rs index 4ba2531..d6cf928 100644 --- a/src/plugins/currency.rs +++ b/src/plugins/currency.rs @@ -130,11 +130,11 @@ impl Plugin for Currency { false } - fn execute(&mut self, _: &IrcServer, _: &Message) -> Result<(), IrcError> { + fn execute(&self, _: &IrcServer, _: &Message) -> Result<(), IrcError> { panic!("Currency does not implement the execute function!") } - fn command(&mut self, server: &IrcServer, mut command: PluginCommand) -> Result<(), IrcError> { + fn command(&self, server: &IrcServer, mut command: PluginCommand) -> Result<(), IrcError> { if command.tokens.is_empty() { return self.invalid_command(server, &command); diff --git a/src/plugins/emoji.rs b/src/plugins/emoji.rs index 09d5c27..1bb714c 100644 --- a/src/plugins/emoji.rs +++ b/src/plugins/emoji.rs @@ -105,7 +105,7 @@ impl Plugin for Emoji { } } - fn execute(&mut self, server: &IrcServer, message: &Message) -> Result<(), IrcError> { + fn execute(&self, server: &IrcServer, message: &Message) -> Result<(), IrcError> { match message.command { Command::PRIVMSG(_, ref content) => { self.emoji(server, content, message.response_target().unwrap()) @@ -114,7 +114,7 @@ impl Plugin for Emoji { } } - fn command(&mut self, server: &IrcServer, command: PluginCommand) -> Result<(), IrcError> { + fn command(&self, server: &IrcServer, command: PluginCommand) -> Result<(), IrcError> { server.send_notice(&command.source, "This Plugin does not implement any commands.") } diff --git a/src/plugins/help.rs b/src/plugins/help.rs index c4ddcd4..8f3fb4d 100644 --- a/src/plugins/help.rs +++ b/src/plugins/help.rs @@ -21,11 +21,11 @@ impl Plugin for Help { false } - fn execute(&mut self, _: &IrcServer, _: &Message) -> Result<(), IrcError> { + fn execute(&self, _: &IrcServer, _: &Message) -> Result<(), IrcError> { panic!("Help does not implement the execute function!") } - fn command(&mut self, server: &IrcServer, command: PluginCommand) -> Result<(), IrcError> { + fn command(&self, server: &IrcServer, command: PluginCommand) -> Result<(), IrcError> { self.help(server, command) } } |
